optimize throttler

add key for IThrottler to remove IThrottler from map when it was executed to avoid memory leak.
webzard-io · Jan 14, 2022 · e44f82b · e44f82b
1 parent 51a5a3d
commit e44f82b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/util/throttler.ts b/src/util/throttler.ts
@@ -7,6 +7,7 @@ export interface IThrottler {
   invoker: (() => void) | null;
   timeout: number | null;
   previous: number;
+  key: symbol;
 }
 
 export class ThrottleManager {
@@ -32,6 +33,7 @@ export class ThrottleManager {
           invoker: null,
           timeout: null,
           previous: 0,
+          key,
         };
         manager.throttlerMap.set(key, newThrottler);
       }
@@ -51,6 +53,7 @@ export class ThrottleManager {
         throttler.previous = now;
         func.apply(this, args);
         manager.pendingFnSet.delete(throttler.invoker);
+        manager.throttlerMap.delete(throttler.key);
         throttler.invoker = null;
       } else if (!throttler.timeout && options.trailing !== false) {
         const debouncedFn = () => {
@@ -59,6 +62,7 @@ export class ThrottleManager {
           throttler.timeout = null;
           func.apply(this, args);
           manager.pendingFnSet.delete(throttler.invoker);
+          manager.throttlerMap.delete(throttler.key);
           throttler.invoker = null;
         };
         throttler.timeout = window.setTimeout(debouncedFn, remaining);

diff --git a/typings/util/throttler.d.ts b/typings/util/throttler.d.ts
@@ -6,6 +6,7 @@ export interface IThrottler {
     invoker: (() => void) | null;
     timeout: number | null;
     previous: number;
+    key: symbol;
 }
 export declare class ThrottleManager {
     private throttlerMap;