Wrapping the .cancel() call with setImmediate to mitigate the error #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan
reviewed
May 22, 2021
| @@ -92,7 +92,7 @@ test('integration testing', async (t) => { | |||
| * Close Client & Server | |||
| */ | |||
| await new Promise(resolve => setImmediate(resolve)) | |||
| eventStream.cancel() | |||
| setImmediate(() => eventStream.cancel()) | |||
There was a problem hiding this comment.
Thanks for the PR!
Cloud you please explain whether it's necessary to change .cacel() to setImmediate(.cacel()) when we have already a await new Promise(resolve => setImmediate(resolve)) above?
I think we have already achieved the same goal with the await new Promise(resolve => setImmediate(resolve)) because it has waited for the event loop to be cleared before we call .cacel(),
iamrajiv
changed the title
iamrajiv
changed the title
iamrajiv
changed the title
iamrajiv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #130