-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please consider to upgrade FlashStore from v0.7 to v0.14 #124
Comments
Sounds great, however, the backend server is unstable recently, let's postpone this change util it get fully fixed. |
Will upgrade this in |
Merged, please check. |
Great. Let's monitor is there's any segmentation fault with v0.3 |
I can not start Here is the issue that I created related to this issue: Will upgrade to |
I'd like to suggest you delete all the old db files before you start to use the new code. Because I believe the RocksDB and LevelDB might not compatible between binary files. |
Okay, delete the old db files works for me. Is there a way to auto detect the file existence and incompatible then auto delete these files? So the upgrade will be much more smoother. Is this technically possible? Since this is upgrading from old version to new, if this requires manually delete the db files, it requires too much work from the users. |
I believe it will have some way to detect, however, I have no idea right now. Or you should consider keeping using the LevelDB version instead to upgrade to the RocksDB version. If you want to do so, I'll publish a new version of FlashStore with the official LevelDB version for you, for replacing the developing version v0.7. |
Will you consider adding a parameter or some environment variable that will control the underlying data store for What do you think about this? |
The FlashStore v0.7 is using
nosql-leveldb
which can fix the segfault fromleveldown
.However, the v0.7 has a dependencies from my test environment
zixia/levelup
. See:https://github.com/huan/flash-store/blob/7c776572ba4ce55840012bb292ce2c520fadf519/package.json#L41
Recently, FlashStore upgrade to using the RocksDB from facebook (See huan/flash-store#34), which I hope could solve the segfault problem too.
So I'd like to suggest that we merge #121 to start using the latest version of FlashStore, and then we can monitor if it will be good for us.
The text was updated successfully, but these errors were encountered: