Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option for where to force push #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add option for where to force push #31

wants to merge 3 commits into from
+12 −2

Conversation

Rory-Z
Copy link

@Rory-Z Rory-Z commented Mar 5, 2021

No description provided.

wei
wei requested changes May 29, 2021
View reviewed changes
Copy link
Owner

@wei wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not backwards compatible. Perhaps negate the logic?

git-sync.sh
@@ -6,6 +6,7 @@ SOURCE_REPO=$1
SOURCE_BRANCH=$2
DESTINATION_REPO=$3
DESTINATION_BRANCH=$4
DESTINATION_FORCE_PUSH=$5
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is unused.

rivy
rivy reviewed Oct 2, 2022
View reviewed changes
Copy link

@rivy rivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should make the PR backwards-compatible.

README.md Outdated Show resolved Hide resolved
git-sync.sh Outdated Show resolved Hide resolved
rivy
rivy suggested changes Oct 2, 2022
View reviewed changes
Copy link

@rivy rivy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These above changes should make the PR backwards-compatible.

Rory-Z and others added 2 commits October 2, 2022 17:08
@Rory-Z @rivy
Update git-sync.sh
1caa7ba 
Co-authored-by: Roy Ivy III <[email protected]>
@Rory-Z @rivy
Update README.md
ef6ef8b 
Co-authored-by: Roy Ivy III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wei wei wei requested changes

@rivy rivy rivy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rory-Z @rivy @wei