sync rg changes

fix describe/list rg err msg (milvus-io#1291) fix load collection (milvus-io#1293) add param check (milvus-io#1297) expose rg info in replica (milvus-io#1305) Signed-off-by: Wei Liu <[email protected]>
weiliu1031 · Feb 22, 2023 · cca5b88 · cca5b88
1 parent 9e4b20f
commit cca5b88
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 4 deletions.
diff --git a/examples/resource_group.py b/examples/resource_group.py
@@ -53,12 +53,14 @@ def transfer_replica(source, target, collection_name, num_replica):
     utility.transfer_replica(
         source, target, collection_name, num_replica, using=_CONNECTION_NAME)
 
+
 def run(): 
     create_connection("root", "123456")
     coll = create_collection(_COLLECTION_NAME, _ID_FIELD_NAME, _VECTOR_FIELD_NAME)
     vectors = insert(coll, 10000, _DIM)
     coll.flush()
     create_index(coll, _VECTOR_FIELD_NAME)
+    load_collection(coll)
 
     create_resource_group("rg")
     list_resource_groups()
@@ -74,6 +76,12 @@ def run():
     describe_resource_group(DEFAULT_RESOURCE_GROUP)
     describe_resource_group("rg")
 
+    describe_resource_group(DEFAULT_RESOURCE_GROUP)
+    describe_resource_group("rg")
+    transfer_replica("rg", DEFAULT_RESOURCE_GROUP, _COLLECTION_NAME, 1)
+    describe_resource_group(DEFAULT_RESOURCE_GROUP)
+    describe_resource_group("rg")
+
     describe_resource_group(DEFAULT_RESOURCE_GROUP)
     describe_resource_group("rg")
     transfer_replica("rg", DEFAULT_RESOURCE_GROUP, _COLLECTION_NAME, 1)

diff --git a/pymilvus/client/check.py b/pymilvus/client/check.py
@@ -344,6 +344,7 @@ def __init__(self) -> None:
             "operate_privilege_type": is_legal_operate_privilege_type,
             "properties": is_legal_collection_properties,
             "replica_number": is_legal_replica_number,
+            "resource_group_name": is_legal_table_name,
         }
 
     def check(self, key, value):

diff --git a/pymilvus/client/grpc_handler.py b/pymilvus/client/grpc_handler.py
@@ -1043,7 +1043,8 @@ def get_replicas(self, collection_name, timeout=None, **kwargs) -> Replica:
         groups = []
         for replica in response.replicas:
             shards = [Shard(s.dm_channel_name, s.node_ids, s.leaderID) for s in replica.shard_replicas]
-            groups.append(Group(replica.replicaID, shards, replica.node_ids))
+            groups.append(Group(replica.replicaID, shards, replica.node_ids, replica.resource_group_name,
+                                replica.num_outbound_node))
 
         return Replica(groups)
 

diff --git a/pymilvus/client/prepare.py b/pymilvus/client/prepare.py
@@ -822,10 +822,12 @@ def get_server_version(cls):
 
     @classmethod
     def create_resource_group(cls, name):
+        check_pass_param(resource_group_name=name)
         return milvus_types.CreateResourceGroupRequest(resource_group=name)
 
     @classmethod
     def drop_resource_group(cls, name):
+        check_pass_param(resource_group_name=name)
         return milvus_types.DropResourceGroupRequest(resource_group=name)
 
     @classmethod
@@ -834,16 +836,21 @@ def list_resource_groups(cls):
 
     @classmethod
     def describe_resource_group(cls, name):
+        check_pass_param(resource_group_name=name)
         return milvus_types.DescribeResourceGroupRequest(resource_group=name)
 
     @classmethod
     def transfer_node(cls, source, target, num_node):
+        check_pass_param(resource_group_name=source)
+        check_pass_param(resource_group_name=target)
         return milvus_types.TransferNodeRequest(source_resource_group=source,
                                                 target_resource_group=target,
                                                 num_node=num_node)
 
     @classmethod
     def transfer_replica(cls, source, target, collection_name, num_replica):
+        check_pass_param(resource_group_name=source)
+        check_pass_param(resource_group_name=target)
         return milvus_types.TransferReplicaRequest(source_resource_group=source,
                                                    target_resource_group=target,
                                                    collection_name=collection_name,

diff --git a/pymilvus/client/types.py b/pymilvus/client/types.py
@@ -311,10 +311,12 @@ def shard_leader(self) -> int:
 
 
 class Group:
-    def __init__(self, group_id: int, shards: list, group_nodes: list):
+    def __init__(self, group_id: int, shards: list, group_nodes: list, resource_group: str, num_outbound_node: dict):
         self._id = group_id
         self._shards = shards
         self._group_nodes = tuple(group_nodes)
+        self._resource_group = resource_group
+        self._num_outbound_node = num_outbound_node
 
     def __repr__(self) -> str:
         s = f"Group: <group_id:{self.id}>, <group_nodes:{self.group_nodes}>, <shards:{self.shards}>"
@@ -332,6 +334,13 @@ def group_nodes(self):
     def shards(self):
         return self._shards
 
+    @property
+    def resource_group(self):
+        return self._resource_group
+
+    @property
+    def num_outbound_node(self):
+        return self._num_outbound_node
 
 class Replica:
     """

diff --git a/tests/test_types.py b/tests/test_types.py
@@ -9,7 +9,7 @@
 # is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
 # or implied. See the License for the specific language governing permissions and limitations under the License.
 
-from pymilvus import DataType
+from pymilvus import DataType, DEFAULT_RESOURCE_GROUP
 from pymilvus.exceptions import InvalidConsistencyLevel
 from pymilvus.client.types import (
     get_consistency_level, ConsistencyLevel,
@@ -128,7 +128,7 @@ def test_shard(self):
         assert s.shard_leader == 1
         print(s)
 
-        g = Group(2, [s], [1, 2, 3])
+        g = Group(2, [s], [1, 2, 3], DEFAULT_RESOURCE_GROUP, {})
         assert g.id == 2
         assert g.shards == [s]
         assert g.group_nodes == (1, 2, 3)