Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TS GitHub action #11203

Closed
rcantin-w opened this issue Sep 25, 2024 · 1 comment
Closed

Improve TS GitHub action #11203

rcantin-w opened this issue Sep 25, 2024 · 1 comment
Assignees
@rcantin-w

Comments

@rcantin-w
Copy link
Contributor

We could improve our tsc Github Action:

  • Only run when workspace changes happen?
  • Add tsc run to others like dash for when it changes (it currently only runs in the main workspaces and playwright).
@rcantin-w rcantin-w converted this from a draft issue Sep 25, 2024
@rcantin-w rcantin-w self-assigned this Sep 25, 2024
@rcantin-w rcantin-w moved this from Backlog to In progress in Digital experience Sep 25, 2024
@rcantin-w rcantin-w mentioned this issue Sep 25, 2024
Merged
@rcantin-w
Copy link
Contributor Author

Only run when workspace changes happen?

See related PR, could've pushed harder to make it happen but I don't think it was something to prioritise

Added dash and updown as the other two subrepos using TS.

@github-project-automation github-project-automation bot moved this from Ready for review to Done in Digital experience Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcantin-w rcantin-w

Labels
None yet
Projects
Digital experience
Status: Archive
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcantin-w