Run tsc on all TS repos, trial path-files to filter out when they run
#11204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -1.19 kB (-0.12%) Total Size: 982 kB
ℹ️ View Unchanged
|
rcantin-w
changed the title
tsc on all TS repos, trial path-files to filter out when they run
davidpmccormick
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Relates to #11203
Adds the
dashandupdownrun.Final version of this PR
Removed the part below, we won't be filtering on running only the repos with changes as it ran them against main the whole time, which means that PRs (e.g.
branch-b) that should be compared against a parent PR (e.g.branch-a) would suffer from the same fails their parents to, even though the work inbranch-bmight have nothing to do with the fail.Changes will be within
workspaces95% of the time anyway, so running the others alongside it doesn't add anything to the build time, as they're all under 30 seconds.First version of this PR
Uses https://github.com/dorny/paths-filter?tab=readme-ov-file to filter paths, determining which
tsctests should be run. The patch upgrades were to test the various tsc runs.Note
This compares your branch to
main. It's not per commit changes, but the whole of the PR. So if you've changed a file inuploadfirst, then inplaywright, they'll both consequently always run every commit this PR has. I wondered if that was unwanted behaviour (and so did others), but really, I think it's a good idea, especially if the PRs might get longer lived, or the fix lived outside of the folders.How to test
Create PRs with various changes and see if the relevant checks are run
How can we measure success?
Saves times/resources, but flags are still raised when relevant.
Have we considered potential risks?
N/A