Changed service definition + fixed testcases #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nightbr Phpsepc still fails because the function subscriberHash is now static in DrewM\MailChimp. Any idea on how to fix this? |
Nightbr
requested changes
Oct 19, 2019
There was a problem hiding this comment.
If you want to use ids for services, you have to set class manually (no autowire here).
For the problem with drewm/mailchimp-api. You need to replace in ListRepository.php:
$this->mailchimp->subscriberHash by MailChimp::subscriberHash because subscriberHash became a static method.
After that, you need to fix ListRepositoryTest.php (no time for this, sorry, but if you can manage it, we will be able to merge this and release a version 👍 ).
Welp/MailchimpBundle/Subscriber/ListRepository
48 - it subscribe a subscriber
unexpected method call on Double\DrewM\MailChimp\MailChimp\P34:
- put(
"lists/ba039c6198/members/b1a29fd58778c40c7f15f06a334dc691",
["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "subscribed"]
)
expected calls were:
- subscriberHash(
exact("[email protected]")
)
- success(
)
- get(
exact("lists/ba039c6198")
)
- get(
exact("lists/notfound")
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "subscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "unsubscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "pending"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "cleaned"])
)
Welp/MailchimpBundle/Subscriber/ListRepository
59 - it unsubscribe a subscriber
unexpected method call on Double\DrewM\MailChimp\MailChimp\P36:
- put(
"lists/ba039c6198/members/b1a29fd58778c40c7f15f06a334dc691",
["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "unsubscribed"]
)
expected calls were:
- subscriberHash(
exact("[email protected]")
)
- success(
)
- get(
exact("lists/ba039c6198")
)
- get(
exact("lists/notfound")
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "subscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "unsubscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "pending"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "cleaned"])
)
Welp/MailchimpBundle/Subscriber/ListRepository
64 - it pending a subscriber
unexpected method call on Double\DrewM\MailChimp\MailChimp\P38:
- put(
"lists/ba039c6198/members/b1a29fd58778c40c7f15f06a334dc691",
["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "pending"]
)
expected calls were:
- subscriberHash(
exact("[email protected]")
)
- success(
)
- get(
exact("lists/ba039c6198")
)
- get(
exact("lists/notfound")
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "subscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "unsubscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "pending"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "cleaned"])
)
Welp/MailchimpBundle/Subscriber/ListRepository
69 - it clean a subscriber
unexpected method call on Double\DrewM\MailChimp\MailChimp\P40:
- put(
"lists/ba039c6198/members/b1a29fd58778c40c7f15f06a334dc691",
["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "cleaned"]
)
expected calls were:
- subscriberHash(
exact("[email protected]")
)
- success(
)
- get(
exact("lists/ba039c6198")
)
- get(
exact("lists/notfound")
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "subscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "unsubscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "pending"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "cleaned"])
)
Welp/MailchimpBundle/Subscriber/ListRepository
74 - it delete a subscriber
unexpected method call on Double\DrewM\MailChimp\MailChimp\P42:
- delete(
"lists/ba039c6198/members/b1a29fd58778c40c7f15f06a334dc691"
)
expected calls were:
- subscriberHash(
exact("[email protected]")
)
- success(
)
- get(
exact("lists/ba039c6198")
)
- get(
exact("lists/notfound")
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "subscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "unsubscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "pending"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "cleaned"])
)
- delete(
exact("lists/ba039c6198/members/md5ofthesubscribermail")
)
Welp/MailchimpBundle/Subscriber/ListRepository
81 - it update a subscriber
unexpected method call on Double\DrewM\MailChimp\MailChimp\P44:
- patch(
"lists/ba039c6198/members/b1a29fd58778c40c7f15f06a334dc691",
["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html"]
)
expected calls were:
- subscriberHash(
exact("[email protected]")
)
- success(
)
- get(
exact("lists/ba039c6198")
)
- get(
exact("lists/notfound")
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "subscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "unsubscribed"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "pending"])
)
- put(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html", "status" => "cleaned"])
)
- patch(
exact("lists/ba039c6198/members/md5ofthesubscribermail"),
exact(["email_address" => "[email protected]", "merge_fields" => ["FNAME" => "Charles", "LNAME" => "Terrasse"], "language" => "fr", "email_type" => "html"])
)
|
Add to that, I think we should lock the version of drewm/mailchimp-api to 2.5.* to avoid this sort of thing in the future. composer.json |
|
So i changed "md5ofthesubscribermail" for the md5 hash of the test email because you can not mock a static method. In there Github they suggest to create your own wrapper/proxy but that might be a little to much for this one thing? |
jeroendk
force-pushed
the
consistant_services
branch
from
188d748
to
b6fb581
Compare
Nightbr
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #27 I think it is better to use keys for the service definition, also most of the services already had keys so this is more consistent.
In addition i fixed the failing tests.