fix: symfony 4.3 deprecation - #32 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @Nightbr |
|
You're welcome, if you want I can set you as maintainer because I really don't use this in my projects anymore (move from Mailchimp for good & recently move from PHP/Symfony to TypeScript/Nestjs). So don't hesitate ;) |
|
It would be a pleasure but like you I don't use mailchimp anymore, it was just to upgrade a legacy customer project, sorry about that! thanks again for the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix
A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.