Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing device_class from 2021.12.1 on #171

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Conversation

weltenwort
Copy link
Owner

@weltenwort weltenwort commented Dec 16, 2021

📝 Summary

This moves the device_class down the RctPowerSensorEntity inheritance hierarchy to adapt to the fact that the SensorEntity now overrides the device_class property of the base Entity.

closes #170

🕵️‍♀️ Notes

When the integration was installed in a Home Assistant instance for the first time before this fix but after upgrading, the recorder might have incorrectly recorded statistics using W and Wh instead of the kW and kWh expected by the Energy dashboard. In order for the entities to be selectable in the Energy configuration again, it might be necessary to use the "Fix it" feature of the "Statistics" tab in the developer tools.

❤️ Attribution

Thanks to @pluskal for first reporting it and to @Benjamin410 for assisting in the investigation.

@weltenwort weltenwort added bug Something isn't working minor version This change warrants a minor release labels Dec 16, 2021
@weltenwort weltenwort self-assigned this Dec 16, 2021
@github-actions
Copy link

🎉 HACS repository validator action summary 🎉
✅ The repository is not archived
✅ manifest.json file exist
✅ All required keys are present in manifest.json
✅ hacs.json has the 'name' key set
✅ The repository has a description
✅ rct_power is added to https://github.com/home-assistant/brands NICE!
✅ The repository has topics
✅ The repository has issues enabled
✅ This day ends with an 'y' (Thursday)
✅ info.md exists
✅ Requirements validation
✅ HACS load check

@weltenwort weltenwort merged commit 861affc into main Dec 16, 2021
@weltenwort weltenwort deleted the fix-2021-12-device-class branch December 16, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor version This change warrants a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Energy broken on 2021.12
1 participant