Use native_unit_of_measurement to prevent recursion. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RctPowerSensorEntity the device_class() method used to use unit_of_measurement() to get the unit of measurement for the entity. This no longer works, as with HA 2022.5.0 this implies a recursion back to unit_of_measurement() within the HA device_class() method to figure out if the entity is temperature based. Thus using native_unit_of_measurement() instead.
|
Hey @pfetzing, thanks for submitting this. I'll review it today! |
weltenwort
added
bug
weltenwort
approved these changes
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RctPowerSensorEntity the device_class() method used to use unit_of_measurement() to get the unit of measurement for the entity. This no longer works, as with HA 2022.5.0 this implies a recursion back to unit_of_measurement() within the HA device_class() method to figure out if the entity is temperature based.
Thus using native_unit_of_measurement() instead.