Make promotion behave the same as alias button (elastic#54608) (elast…

…ic#54704) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
weltenwort · Jan 14, 2020 · 830e8c8 · 830e8c8
1 parent 428fba3
commit 830e8c8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/...plugins/kibana/public/visualize/np_ready/wizard/__snapshots__/new_vis_modal.test.tsx.snap b/...plugins/kibana/public/visualize/np_ready/wizard/__snapshots__/new_vis_modal.test.tsx.snap
diff --git a/...core_plugins/kibana/public/visualize/np_ready/wizard/type_selection/new_vis_help.test.tsx b/...core_plugins/kibana/public/visualize/np_ready/wizard/type_selection/new_vis_help.test.tsx
@@ -41,7 +41,7 @@ describe('NewVisHelp', () => {
               stage: 'production',
             },
           ]}
-          addBasePath={(url: string) => `testbasepath${url}`}
+          onPromotionClicked={() => {}}
         />
       )
     ).toMatchInlineSnapshot(`
@@ -60,9 +60,9 @@ describe('NewVisHelp', () => {
         </p>
         <EuiButton
           fill={true}
-          href="testbasepath/my/fancy/new/thing"
           iconSide="right"
           iconType="popout"
+          onClick={[Function]}
           size="s"
         >
           Do it now!

diff --git a/...gacy/core_plugins/kibana/public/visualize/np_ready/wizard/type_selection/new_vis_help.tsx b/...gacy/core_plugins/kibana/public/visualize/np_ready/wizard/type_selection/new_vis_help.tsx
@@ -21,10 +21,11 @@ import { FormattedMessage } from '@kbn/i18n/react';
 import React, { Fragment } from 'react';
 import { EuiText, EuiButton } from '@elastic/eui';
 import { VisTypeAliasListEntry } from './type_selection';
+import { VisTypeAlias } from '../../../../../../visualizations/public';
 
 interface Props {
   promotedTypes: VisTypeAliasListEntry[];
-  addBasePath: (path: string) => string;
+  onPromotionClicked: (visType: VisTypeAlias) => void;
 }
 
 export function NewVisHelp(props: Props) {
@@ -42,7 +43,7 @@ export function NewVisHelp(props: Props) {
             <strong>{t.promotion!.description}</strong>
           </p>
           <EuiButton
-            href={props.addBasePath(t.aliasUrl)}
+            onClick={() => props.onPromotionClicked(t)}
             fill
             size="s"
             iconType="popout"

diff --git a/...cy/core_plugins/kibana/public/visualize/np_ready/wizard/type_selection/type_selection.tsx b/...cy/core_plugins/kibana/public/visualize/np_ready/wizard/type_selection/type_selection.tsx
@@ -154,7 +154,7 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
                   <EuiSpacer size="m" />
                   <NewVisHelp
                     promotedTypes={(visTypes as VisTypeAliasListEntry[]).filter(t => t.promotion)}
-                    addBasePath={this.props.addBasePath}
+                    onPromotionClicked={this.props.onVisTypeSelected}
                   />
                 </React.Fragment>
               )}