-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul hanzi2num #413
Merged
Merged
Overhaul hanzi2num #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds awesome, looking forward to it 👍 |
statementreply
force-pushed
the
hanzi2num
branch
from
December 28, 2019 12:43
b1fa789
to
5b6fd7f
Compare
Open
Done
Future
Distant Future (?)
|
👍Looks very sophisticated, thanks so much! Will take a closer peek tomorrow :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
hanzi2num
: convert from Chinese number to decimal string without computing its numerical value.num2hanzi
.Behavior Changes
塵埃渺漠
are now 10x each穰
(U+7A70).一百一
= 101 now一
before fractional multipliers is no longer allowed. It's unclear whether五毫絲
means 0.0051 or 5e-7, so I just disallowed it for now.一萬萬
= 1e+8,一百絲
= 0.01.一三三七
= 1337〇
(exactly one digit of zero) and decimal separator·
:三五〇〇·〇一
= 3500.01