feature: WEOS-1308 As a developer I should be able to add data to the context via the api sepcification #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Updated spec file to have the correct db config
-Generated bdd test
…rom x-context and add to the context -Added test for getting the params from x-context and adding it to the context -Added functionality for getting the params from x-context and putting it into the context -Added openapi extension x-context
-Updated the spec file -Debug the BDD test
-Updated the spec file -Debug the BDD test
-Added a warning if the parameters in the x-context is not one of the default parameters
feature: WEOS-1308 Generate and ensure BDD Test is passing
# Conflicts: # controllers/rest/middleware_context_test.go # end2end_test.go
akeemphilbert
requested changes
Feb 23, 2022
…rom x-context and add to the context -Updated parse params to put the parameters into a map -Added a function to put the map of parameter values in the context
# Conflicts: # controllers/rest/middleware_context.go
…rom x-context and add to the context -Updated parse params to put the parameters into a map -Added a function to put the map of parameter values in the context and convert properties to the correct data types
…rom x-context and add to the context -Fixing any test that fails
…rom x-context and add to the context -Fixing any test that fails
feature: WEOS-1308 Update the context middleware to take parameters from x-context and add to the context
akeemphilbert
requested changes
Feb 28, 2022
… context via the api specification -Update parse params to only parse the parameters -update addtocontext to convert the values and add to the context -Ensure tests are passing
# Conflicts: # controllers/rest/openapi_extensions.go
# Conflicts: # controllers/rest/middleware_context.go # controllers/rest/openapi_extensions.go # end2end_test.go
# Conflicts: # end2end_test.go
…be returned if there is no controller set -Updated controller
…be returned if there is no controller set -Updated controller
Aidan-E
previously approved these changes
Mar 7, 2022
… context via the api specification -Added checks so if nothing is passed in the request it should be removed from the map
… context via the api specification -Added skipped tag to 1365 since it is being worked on, on another ticket
… context via the api sepcification -Debug an issue
Aidan-E
approved these changes
Mar 7, 2022
akeemphilbert
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: