Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/weos 1341 - As a developer I should be able to mark a fields as unique #117

Merged
merged 16 commits into from
Feb 28, 2022

Conversation

atoniaw
Copy link
Contributor

@atoniaw atoniaw commented Feb 23, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

atoniaw and others added 11 commits February 18, 2022 14:52
added unique tag using gorm
added unique test in projections
feature/WEOS-1355 - Add gorm tag for unique field on entity.  Make getbyidentifiers method in projections.
added unique validation in domain service
updated receiver functions sto use unique validator whee necessary
added integration test for unique constraint
fixed batch create handler in module
feature/WEOS-1358 Add integration tests
projections/gorm.go Outdated Show resolved Hide resolved
Copy link
Contributor

@akeemphilbert akeemphilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a GetByKey method on the projection why isn't this used?

changed projections function name from GetByIdentifiers to GetByProperties
@akeemphilbert akeemphilbert merged commit 0c030e8 into dev Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants