-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: WEOS-1342 As a developer I should be able have a datetime field automatically update on update #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added operationId to the context added update time function to the model
- completed update time func and added unit test
Weos 1359 - As a developer I should be able have a datetime field automatically update on update
…WEOS-1342 # Conflicts: # model/receiver.go
Aidan-E
previously approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Points achieved👍🏾
# Conflicts: # model/content_entity_test.go
# Conflicts: # controllers/rest/api_test.go
Aidan-E
previously approved these changes
Mar 7, 2022
# Conflicts: # controllers/rest/middleware_context_test.go
…on date fields * Added scenario to show how it works to set a created date field * Added scenario to show how it works to update an updated date field * Added scenario to show invalid operation id being set in x-update
- Generated Steps
- WIP
- Updated api.go to have a check for x-update (if the provided is valid) - Updated e2e tests
- Added a switch for db type since time.Time is handled differently across dbs
- Added case for mysql
# Conflicts: # end2end_test.go
Aidan-E
previously approved these changes
Mar 14, 2022
akeemphilbert
requested changes
Mar 14, 2022
# Conflicts: # controllers/rest/api_test.go
- Fixed e2e step(theFieldShouldHaveTodaysDate) to be more dynamic - Removed local copy in UpdateTime func
Aidan-E
previously approved these changes
Mar 15, 2022
# Conflicts: # controllers/rest/api_test.go
# Conflicts: # controllers/rest/api_test.go # end2end_test.go # model/content_entity.go # model/content_entity_test.go # model/receiver.go
…eld automatically update on update -Updated functionality
…WEOS-1342 # Conflicts: # controllers/rest/api_test.go
akeemphilbert
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
-Date-Time properties can be updated automatically once specified in the yaml file
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: