Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: WEOS-1382 As a developer I should be able to set the type of id that I want auto generated #138

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

shaniah868
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

-Identifier can be generated once a format is specified
-If not format is specified then an error is thrown on creation

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

… id that I want auto generated

-Added GenerateID function to the content entity file
-Fix all create content type test in the receiver
-Added a test in the content type for generateid
-Updated fixture for the test
… id that I want auto generated

-Updating the functionality in Generatedid
-Updated create schema to check for the format of the integer property and if its uint add it as that
-Updated test functionality
-Add Generateid to return domain errors
… id that I want auto generated

-Added some log lines to errors
@shaniah868 shaniah868 requested a review from RandyDeo March 9, 2022 17:32
@RandyDeo RandyDeo merged commit c374436 into feature/WEOS-1382 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants