Weos 1394 - As a developer I should be able to set a middleware to handle file uploads #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added functionality to the form util func - Updated the form util func call with the properties - Updated feature file - Generated steps and completed 1 scenario
# Conflicts: # end2end_test.go
- Work in progress
- Updated feature file - Wrapped up e2e test, all passing - Added to the context func - Updated utils func
- Added unit tests
- Updated e2e tests - updated feature file - updated integration test - updated middleware context (removed case for ct) - updated test20 file - Removed binary func in utils - Added helper func in utils for ConvertFormtoJson func
# Conflicts: # end2end_test.go
- Updated utils test
…e to handle file uploads -Added functionality to return an error for uplaoding
- Working on getting correct error output/responses - Issue is that file upload would still happen even if the post event failed.
- Fixed the issue with the wrong error being returned - Issue is that file upload would still happen even if the post event failed.
- Fixed an integration test
- Added a test and adjusted and tested functionality
# Conflicts: # controllers/rest/middleware_context.go # controllers/rest/utils.go # controllers/rest/utils_test.go # end2end_test.go
- Merged dev - Updated utils func - Updated middleware context with upload funcitonality
- Fixed error output
shaniah868
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: