bug: Fixed issue where form values were being marshalled as string only #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved ConvertFormToJson to the context middleware (it isn't used anywhere else) * Updated ConvertFormToJson signature to receive schema so that it could be used to coerce the type * Updated ConvertFormToJson so that arrays are handled correctly * Add ConvertStringToType utility function that could be used to convert OpenAPI data type to golang type * Refactored convertProperties so that it uses the new ConvertStringToType utility function so that conversions are consistent. It also reduced the lines of code * Fixed the parameter reference in the README.md so that it's correct
* Refactored form data parsing so that the same code could be used for both application/x-www-form-urlencoded and multipart/form-data
* In the getter functions title cased the property name (this was being done for string only)
RandyDeo
approved these changes
Mar 21, 2022
shaniah868
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Moved ConvertFormToJson to the context middleware (it isn't used anywhere else)
Updated ConvertFormToJson signature to receive schema so that it could be used to coerce the type
Updated ConvertFormToJson so that arrays are handled correctly
Add ConvertStringToType utility function that could be used to convert OpenAPI data type to golang type
Refactored convertProperties so that it uses the new ConvertStringToType utility function so that conversions are consistent. It also reduced the lines of code
Fixed the parameter reference in the README.md so that it's correct
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: