Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: WEOS-1384 As a developer I should be able to specify a Go template I want to use to render a response #149

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

shaniah868
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Go templates can now be rendered and returned
  • Data that is needed must be added to the context in order to fill out the template
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

…mplate I want to use to render a response

-Added more test
-Updated feature file
-Debug e2e test
…mplate I want to use to render a response

-Ensure test passes
…mplate I want to use to render a response

-Added helper function to add context values into a map and return
-Updated default middleware for template to use this function
-Added more test to increase coverage
…mplate I want to use to render a response

-Fix the utils function that returns the context values to use reflect package
-Added more test to cover the controller functionality
-Added another endpoint for bad requests
@RandyDeo RandyDeo merged commit 5ab2857 into feature/WEOS-1384 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants