Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: #216 Added BasePath to context #217

Merged
merged 2 commits into from
Aug 23, 2022
Merged

feature: #216 Added BasePath to context #217

merged 2 commits into from
Aug 23, 2022

Conversation

akeemphilbert
Copy link
Contributor

@akeemphilbert akeemphilbert commented Aug 19, 2022

  • Added context key "BASE_PATH" that has the base path from the config

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

featuer

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

Basepath is now available in the request context as well as in the view as BASE_PATH

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

This may break some tests that use a container mock that isn't mocking the GetWeOSCOnfig method

  • Other information:

@akeemphilbert akeemphilbert merged commit 69f24ad into dev Aug 23, 2022
@akeemphilbert akeemphilbert deleted the feature/216 branch August 23, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant