Feature/255 #257
Merged
Feature/255 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nses are handled by the controller * Removed the check on the error type since this could be done in the HTTPErrorHandler that is set by the specific api * Made it so that if the response is a string, the string response type is set instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix and feature
What is the current behavior? (You can also link to an open issue here)
When there is a regular error the library panics
What is the new behavior (if this is a feature change)?
There isn't a type check on the error and the developer is expected to handle error types by setting their own error handler on the echo instance
Additionally if the return type is a string then the string type is used (instead of json)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: