Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature WS-638 #278

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feature WS-638 #278

wants to merge 1 commit into from

Conversation

IshikaGopie
Copy link
Contributor

…gger instead of storing it in a map

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@IshikaGopie IshikaGopie changed the title feature WS-638: updated the container to store one instance of the lo… feature WS-638 Mar 22, 2024
p.logger = logger
}

func (p *RESTAPI) GetLogger() model.Log {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not replace GetLog so that way the change will propogate across all our microservices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants