-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weos 1240 #46
Merged
Merged
Weos 1240 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…weos id added functionality to omit sequence number and weos_id in relations when pulling the entire entity with relations from database
- Added command - Added receiver and test - Added func for update in domain service
- working on an update test
- Worked on the service test - Worked on the update service func - Added to the receiver
- Added todos
Weos 1245
Weos 1256
- Updated command receiver and service
# Conflicts: # projections/gorm.go
- Updated Mocks - Added update to content entity - Tested content entity - Added service - Tested Service - Updated receiver - Testing receiver still - Updated utils to have a getSeqNo
- Updated Receiver and receiver test
# Conflicts: # controllers/rest/api_test.go
- Added & to projections test
- Fixed Receiver
- Added "invalid:" tags to errors
atoniaw
reviewed
Jan 17, 2022
atoniaw
reviewed
Jan 17, 2022
- Made requested changes on the pr - Revisited errors being returned
- Added Validation to service - Found some issues with the service and added code to address that - Added tests for compound keys - Add yaml files for testing - Updated update func in content entity. - Fixed content entity test
atoniaw
approved these changes
Jan 18, 2022
shaniah868
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: