Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/weos 1132 - As a developer I should be able to update an item for a content type #55

Merged
merged 133 commits into from
Jan 27, 2022

Conversation

atoniaw
Copy link
Contributor

@atoniaw atoniaw commented Jan 21, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Allows users to edit a specific item in the database
  • Allows users to see a specific item in the datatabase (WEOS-1135)
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
  • Foreign keys changed to pointers to account for empty foreign keys in payload. The database would not allow for item creation otherwise if the foreign key defaults to a blank string instead of null. This may cause existing databases to become unusable.
  • Other information:

akeemphilbert and others added 30 commits January 7, 2022 03:27
add update projections tests
add update handler for update event in projections
updated prjections update event function to replace associations
added comments within the update event handler
added missing database config to the view-content feature file
updated bdd test
updated bdd test
updated projections to include a get by entity id and a get by keys function
added projections get by entity id test
…weos id

added functionality to omit sequence number and weos_id in relations when pulling the entire entity with relations from database
added a get by key function in projections and added projections test
updated projections get by entity ids and get by keys in order to facilitate gorm  sqlite error
added projections test for reassigning primary key
merged with WEOS-1130 and minor updates to tests
@atoniaw atoniaw marked this pull request as ready for review January 24, 2022 13:16
Aidan-E
Aidan-E previously approved these changes Jan 24, 2022
Copy link

@Aidan-E Aidan-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed all parameters of functional review.

controllers/rest/utils.go Outdated Show resolved Hide resolved
model/utils.go Outdated Show resolved Hide resolved
atoniaw and others added 4 commits January 25, 2022 10:28
Put sequence number in context when updating
moved getcontentbysequencenumber function from controller to model
Put sequence number in context when updating
moved getcontentbysequencenumber function from controller to model
feature: Weos 1307 - Time is parsed for create and update
added note to mysql test for known bug with table creation out of order
akeemphilbert
akeemphilbert previously approved these changes Jan 26, 2022
RandyDeo and others added 2 commits January 26, 2022 09:14
Aidan-E
Aidan-E previously approved these changes Jan 26, 2022
akeemphilbert
akeemphilbert previously approved these changes Jan 26, 2022
@atoniaw atoniaw dismissed stale reviews from akeemphilbert and Aidan-E via 8dafbc3 January 26, 2022 16:49
akeemphilbert
akeemphilbert previously approved these changes Jan 26, 2022
@akeemphilbert akeemphilbert merged commit 5f1e288 into dev Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants