-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: WEOS-1133 As a user I should be able to get a list of items for a content type #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added x-weos-config to the feature file
- Generated bdd test
…tions -Added a test for list method in projection -Added the getcontententities to projection -Added paginate function to help with querying
- Added to the projection query to remove weosid and sequence no from all content entities
…functions -Added sort function that only sorts by the default key id -Added sort into test confirm
…tion -Added another test to make sure the foreign key is being returned
-Added a test for list controller -Added a list api response
feature: WEOS-1133 Create a list method on projection and helper function
-Added page and limmit to the blog ymaml file -Added a check for x-alias to be added to the context -Added a test to make sure x-alias parameters are being added -Regenerate mocks -Added get content entities to projection interface -Added the test for list controller -AAdded functionality for the list controller
feature: WEOS-1133 Update the List Controller to call the projections
-Fix BDD Test -Added checks for if the items are named differently to check for its alias -Added the service is running step -Removed the seqno and entityid from feature file -Removed the table_alias from the content entity returned -Change the feature file entityId and sequenceNo to have the same numbering as db
-Add back the tag
-Added paramter to api yaml file
-Fixed failing tests after the merge
-Fixed failing tests after the merge
…WEOS-1133 # Conflicts: # controllers/rest/middleware_context.go # controllers/rest/weos_mocks_test.go # model/event_repository_mocks_test.go
-Fixed failing tests after the merge
# Conflicts: # controllers/rest/controller_standard.go # controllers/rest/middleware_context.go # controllers/rest/weos_mocks_test.go
-Fixed failing tests after the merge
-Change the tag
feature: WEOS-1133 Generate and Ensure BDD Test
Aidan-E
previously approved these changes
Jan 26, 2022
akeemphilbert
requested changes
Jan 27, 2022
# Conflicts: # end2end_test.go
-Revert feature file
-Revert feature file
-Revert feature file
-Revert feature file
* Updated test expectations since the blog id is a string in the schema and is sorted as a string (which is different from it being an integer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This introduces the feature of being able to get a list of items. The limit and page can be specified and the sort is defaulted to id
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: