feature: WEOS-1134 Update Context Middleware to convert incoming request to the structure needed by List Controller #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est to the structure needed by List Controller -Added helper functions to split the filters -Added tests for the helper functions -Added tests for the middleware context -Added functionality for adding filters to the context -Add a filter property that holds the filter information
…est to the structure needed by List Controller -Added functionality to check for an array of values -Added tests for it
…est to the structure needed by List Controller -Added errors for if the filters were not splitted properly
# Conflicts: # controllers/rest/utils.go
# Conflicts: # controllers/rest/utils.go # controllers/rest/utils_test.go # end2end_test.go
RandyDeo
approved these changes
Feb 1, 2022
# Conflicts: # end2end_test.go
atoniaw
approved these changes
Feb 1, 2022
RandyDeo
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality for adding the filters into the context for use in the other layers.
There is a helper functions to aid this functionality
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: