Feature/weos 1135 - As a user I should be able to see the details of a specific item #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added more unit tests for view controller * Improved existing tests to check for calls on mock objects * Made sequence no. a parameter that is parsed by default (without the developer having to declare it as a parameter) * Added scenarios to the view feature file to cover getting an item with a sequence no with and without the item id * Removed deprecation mark on GetByAggregateAndSequenceRange
# Conflicts: # controllers/rest/controller_standard.go
* Working on fixing issues with BDD test
* Fixed issue where a nil payload broke things
# Conflicts: # end2end_test.go
* Added test for getting entity by id to improve code coverage * Fix issue where the flags were not being added to context
* Removed having sequence_no and use_entity_id by default * added sequence_no and use_entity_id to the path parameters in the blog fixture used in testing
feature: Weos 1310
akeemphilbert
previously approved these changes
Jan 28, 2022
* Make it so that invalid sequence no. returns a bad request * Fix for if the id is an integer and not a string when attempting to use as entity id
Aidan-E
previously approved these changes
Jan 28, 2022
* Switched to getting the events in the controller by using the event repository * Added method to ContentEntity that returns the entity as an interface map whose keys are what was set in the OpenAPI spec * Added constructor for ContentEnty to create with schema and events * Added method to Content entity to convert the name of property in dynamic struct back that what was set in the OpenAPI spec
|
This is to get the latest working version of weos 1135 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: