Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Projections Refactor #72

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

atoniaw
Copy link
Contributor

@atoniaw atoniaw commented Jan 31, 2022

used the entity factory in the projections function
updated projections tests
updated interfaces and mocks

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

used the entity factory in the projections function
updated projections tests
updated interfaces and mocks
@shaniah868 shaniah868 self-requested a review January 31, 2022 17:41
@shaniah868 shaniah868 merged commit 2af8944 into feature/refactor Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants