feature: WEOS-1134 Update list method on projection to accept filter map #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added test for each filter operator -Added the filter properties
-Fleshed out tests for all the operators -Added helper functions for filter
-Added functionality to convert the filters into the types that are in the db
-Fixing projection test
… the filter map -Fix test
-Fix test for all the filters that is supported -Added a test for using mixed filters
# Conflicts: # controllers/rest/dtos.go # projections/gorm.go
# Conflicts: # controllers/rest/dtos.go
-Made changes requested on pr -Updated test
-Made changes requested on pr -Updated test
-Change the in operator code to just take one ?
-Fixed test on different databases
atoniaw
approved these changes
Feb 9, 2022
-Added date check and test for it
atoniaw
approved these changes
Feb 9, 2022
RandyDeo
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Made changes requested on pr
-Updated test
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: