Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/weos 1327 - As a developer I should be able to re-create the model from events #92

Merged
merged 25 commits into from
Feb 14, 2022

Conversation

RandyDeo
Copy link
Contributor

@RandyDeo RandyDeo commented Feb 9, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

akeemphilbert and others added 15 commits February 4, 2022 03:14
- Merged dev
- Merged dev
- Generated bdd steps
- Working on the ReplayEvents
- Working on the ReplayEvents
- Updated Replay events func
- Updated Mocks test
- Added a Builder func to entity factory
- Updated server.go
- Updated repository
- Added to the replay events func
- Added a check to migrate tables that do not exist in gorm (not ideal)
- Other changes
- Working on e2e tests
- Working on E2E tests
- Edited feature file Blogs -> Blog
- Edited replayEvents
- Fixed E2E tests
- reverted gorm
- Edited Interfaces
- Regen Mocks
- Edited server.go
- Edited Replay func
- Edited Replay test
- Edited server.go
- Edited main.go
- Made small edits to e2e
feature:WEOS-1327 As a developer I should be able to re-create the model from events
model/event.go Outdated Show resolved Hide resolved
model/repositories.go Outdated Show resolved Hide resolved
model/repositories.go Outdated Show resolved Hide resolved
- Updated E2E test
- Removed SchemaName from event
- Updated the event dispatcher to return and error
- Updated EventHandler to return an error
- Updated replay events
- Updated replay tests
- Regenerated Mocks
- Updated E2E test
end2end_test.go Outdated Show resolved Hide resolved
model/interfaces.go Outdated Show resolved Hide resolved
model/repositories.go Show resolved Hide resolved
- Made requested changes from pr
# Conflicts:
#	end2end_test.go
Copy link

@Aidan-E Aidan-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I be allowed to update the "created" parameter?
ID is not displayed when creating a blog.
ID is not displayed when requesting a blog with a sequence number.
The delete function only gives a 404 even when requesting with random letters/symbols.

Copy link
Contributor

@akeemphilbert akeemphilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have it run the replay automatically (it would be that I have to set the flag to true but true shouldn't be the default)

RandyDeo and others added 4 commits February 11, 2022 09:04
- Changed the replay flag to false by default
* Recovering a table that was partially updates is tricky
- Removed step for delete single id
akeemphilbert
akeemphilbert previously approved these changes Feb 14, 2022
Aidan-E
Aidan-E previously approved these changes Feb 14, 2022
Copy link

@Aidan-E Aidan-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still functionally sound post-changes. All set to merge👍🏾

# Conflicts:
#	model/interfaces.go
#	projections/gorm.go
- Merged Dev and did some changes (gormdb)
@RandyDeo RandyDeo dismissed stale reviews from Aidan-E and akeemphilbert via e4562f8 February 14, 2022 16:57
@akeemphilbert akeemphilbert merged commit ca8c18e into dev Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants