Generalize schema retriever (#291) #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change Bucket Clearer * Add RegexRouter Transform * Add regexrouter transform * Change topicToTableResolver Methods * Change EnsureExistingTables Method * Change SchemaRegistrySchemaRetriever * Add RecordNameStrategy * change standalone properties * Delete TopicToTableResolver and TopicToTableResolverTest class * Generalise schemaRetriever interface * Change schemaRegistrySchemaRetriever * Change TableClearer Class to clear all tables in a Dataset * Add IdentitySchemaRetriever Class * Change BigQuerySinkTask * Remove TOPIC_TO_TABLES config from BigQuerySinkConfig class * Modify BigQuerySinkConnectorTest and BigQuerySinkTaskTest * Delete SchemaRegistrySchemaRetriever Class * Delete MemorySchemaRetriever Class * Change Writer Classes * Remove extra space * Modify bigQuerySinkTaskTest * Change SchemaManagerTest Class * Fix unit tests, make changes acc to code review * Minor fixes * Fixes according to code review * Add javadoc * Modify SMT
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
============================================
- Coverage 70.87% 66.10% -4.77%
+ Complexity 301 267 -34
============================================
Files 32 32
Lines 1538 1484 -54
Branches 164 152 -12
============================================
- Hits 1090 981 -109
- Misses 390 450 +60
+ Partials 58 53 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already reviewed when merging into
generalize-feature#291