Tweaks from scikit-learn-speed needs #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show benchmark name when exception is raised, fix nearby bug Use stderr
| @@ -58,6 +61,7 @@ def __init__(self, benchmarks, repo_path, repo_url, | |||
| always_clean=always_clean, | |||
| dependencies=module_dependencies) | |||
| self._register_benchmarks() | |||
| self._python = os.environ.get('VBENCH_PYTHON', 'python') | |||
There was a problem hiding this comment.
Even better: default to sys.executable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased (hopefully correctly) my master branch into two different changesets. This one implements several tweaks needed for more useful debugging of failing benchmarks.
The VBENCH_PYTHON environment variable is introduced, for situations where the default
pythonis not the one you want to use. Its purpose is easily replacable by using virtualenv. I am not sure whether this is really a useful addition, but I don't think it hurts, either.