Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle escaped identifiers #28

Conversation

Jackenmen
Copy link
Contributor

Fixes #27

@Jackenmen Jackenmen temporarily deployed to pypi June 19, 2023 14:24 — with GitHub Actions Inactive
@jpgrayson
Copy link
Collaborator

Thanks for this PR, @Jackenmen.

An observation: this implementation follows the spec regarding escaped identifiers being terminated by white space, but all the example escaped identifiers from Vivado contain trailing backslashes (e.g. \<const0>\). Perhaps Vivado uses trailing backslashes instead of or in addition to white space to terminate escaped identifiers? This wouldn't be the first example of someone's VCD implementation straying from the IEEE standard. Anyway, I don't see an action to take at this time.

@jpgrayson jpgrayson merged commit f613631 into westerndigitalcorporation:master Jun 19, 2023
11 checks passed
@Jackenmen Jackenmen deleted the handle_escaped_identifiers branch June 19, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support escaped identifiers
2 participants