libspdm: simplify extern fn type checking #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libspdm version of libspdm_write_certificate_to_nvm() has changed, the C header is different as is the bindgen Rust code. The problem is, we don't get an error that our function no longer matches. For now this is ok, as libspdm only appended arguments, but in the future this could cause breakages. There doesn't appear to be any reasonable way to assert that our function matches the bindgen version. Moving libspdm_write_certificate_to_nvm() to libspdm_rs.rs for example causes errors as there are two copies, but that doesn't help us. The best solution I can think of is to use a test function to check that the two functions at least have the same function pointer. This is the equivilent checks that a C compiler would do using function pointers. This adds the checks for libspdm_write_certificate_to_nvm(), we also need to do the check for all other functions next. Signed-off-by: Alistair Francis <[email protected]>
We don't generate errors or warnings if the function signatures we implement don't match the version in libspdm. So far this has been ok as libspdm only appended arguments, but in the future this could cause breakages. There doesn't appear to be any reasonable way to assert that our function matches the bindgen version. The best solution I can think of is to use a test function to check that the two functions at least have the same function pointer. This is the equivilent checks that a C compiler would do using function pointers. This patch adds a macro that can generate that function (somewhat manually) and then uses that macro for all of the `extern "C"` functions. Signed-off-by: Alistair Francis <[email protected]>
We don't generate errors or warnings if the function signatures we implement don't match the version in libspdm. So far this has been ok as libspdm only appended arguments, but in the future this could cause breakages. There doesn't appear to be any reasonable way to assert that our function matches the bindgen version. This patch adds a macro that can compare a provided function type, to it's bindgen generated type upon expansion. When using this macro, the first argument shall specify the local type, that is, the type of the function as defined within `spdm-utils`. Upon expansion, the macro will type check bindgen generated function against the provided type. All of this shall run only in a `test` context, with no runtime overhead. CI should catch any future failures if `libspdm` has changed. Signed-off-by: Alistair Francis <[email protected]> Signed-off-by: Wilfred Mallawa <[email protected]>
alistair23
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #84 to simplify the testing approach used.