Dev #27
Open
Dev #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changeing the binary configuration image file, possibly, the size of configuration file will be one byte bigger than original size by using seek(). in this case, we choose QUERY_DESC_CONFIGURAION_MAX_SIZE as its length. Signed-off-by: Bean Huo <[email protected]>
IDE 01h in Atrributes is Reserved. Signed-off-by: Bean Huo <[email protected]>
Flags length has been changed, but we didn't update it in the verify_and_set_idn() Signed-off-by: Bean Huo <[email protected]>
WriteBooster related flags are an array of flags, add its index distinguish. Signed-off-by: Bean Huo <[email protected]>
WriteBooster related attributes are an array of attributes, add its index distinguish. Signed-off-by: Bean Huo <[email protected]>
| opt->index, opt->selector, 0, 0, 0); | ||
| tmp->device_level & ARRAY ? | ||
| opt->index : 0, | ||
| opt->selector, 0, 0, 0); |
There was a problem hiding this comment.
I think this is redundant fix, By default in case and user didn't set index, selector the values are 0.
See verify_arg_and_set_default function
| opt->index, opt->selector, 0, 0, 0); | ||
| (tmp->device_level & ARRAY) ? | ||
| opt->index : 0, | ||
| opt->selector, 0, 0, 0); |
There was a problem hiding this comment.
Same as previous one
| @@ -266,7 +266,7 @@ static int verify_and_set_idn(struct tool_options *options) | |||
| } | |||
| break; | |||
| case FLAG_TYPE: | |||
| if (idn > QUERY_FLAG_IDN_PERMANENTLYDISABLEFW) { | |||
| if (idn > QUERY_FLAG_IDN_MAX) { | |||
| @@ -244,7 +244,7 @@ struct query_err_res { | |||
|
|
|||
| struct attr_fields ufs_attrs[] = { | |||
| {"bBootLunEn", BYTE, (URD|UWRT), (READ_ONLY|WRITE_PRSIST), DEV}, | |||
| {"bMAX_DATA_SIZE_FOR_HPB_SINGLE_CMD", BYTE, URD, READ_ONLY, DEV}, | |||
| {ATTR_RSRV()}, | |||
| @@ -806,6 +806,9 @@ static int do_conf_desc(int fd, __u8 opt, __u8 index, char *data_file) | |||
| } | |||
| lseek(data_fd, 0, SEEK_SET); | |||
|
|
|||
| if (file_size > QUERY_DESC_CONFIGURAION_MAX_SIZE) | |||
| file_size = QUERY_DESC_CONFIGURAION_MAX_SIZE; | |||
|
|
|||
There was a problem hiding this comment.
In case an user create the wrong config file. I don't think the tool shall try fix it. Better if the user will receive Invalid length Query error and fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.