Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support caxlsx gem #28

Closed
westonganger opened this issue Oct 28, 2019 · 7 comments
Closed

Support caxlsx gem #28

westonganger opened this issue Oct 28, 2019 · 7 comments

Comments

@westonganger
Copy link
Owner

A new gem caxlsx (Community Axlsx) has been released, Spreadsheet Architect should support this.
@westonganger
Copy link
Owner Author

Pending resolution to caxlsx/caxlsx#31

@arambert
Copy link

any news on this?

@westonganger
Copy link
Owner Author

westonganger commented Jan 23, 2020 •
edited
Loading

@arambert was kind of just waiting to examine caxlsx development. Seems to be stable. Maybe I will find some time next week to try and implement this.

It will have to be a new major version release. I would also like to try to add xlsx freeze functionality (#25) for this release as well.

@westonganger
Copy link
Owner Author

westonganger commented Jan 25, 2020 •
edited
Loading

caxlsx integration has now been implemented in master. @arambert please test and let me know how it works out for you.

@westonganger
Copy link
Owner Author

We are pretty much ready to cut a new release. I would like to see the outcome of caxlsx/caxlsx#44 first though.

freesteph added a commit to openregister/registers-frontend that referenced this issue Feb 11, 2020
@freesteph
fix: upgrade spreadsheet_architect to remove hard axlsx dependency
52ff9aa 
spreadsheet_architect already pulls-in a newer version of axlsx that
does not have the security vulnerability[1] in it. Ideally we should keep
an eye on the imminent release[2] of spreadsheet_architect that moves
away from axlsx in favour of the community-maintained caxlsx[3].

[1]: randym/axlsx#536
[2]: westonganger/spreadsheet_architect#28 (comment)
[3]: westonganger/spreadsheet_architect@3a6f02d#diff-4ac32a78649ca5bdd8e0ba38b7006a1e
@freesteph freesteph mentioned this issue Feb 11, 2020
Merged
freesteph added a commit to openregister/registers-frontend that referenced this issue Feb 11, 2020
@freesteph
fix: upgrade spreadsheet_architect to remove axlsx dependency
029f20c 
spreadsheet_architect will soon be released[1] with the axlsx
dependency removed, in favour of the community-maintained caxlsx[2]
that does not have the security vulnerability of the former[3].

Ideally we should keep an eye on that release and pin it down in our
Gemfile but until then roll with the master branch as it seems to be
working just fine.

[1]: westonganger/spreadsheet_architect#28 (comment)
[2]: westonganger/spreadsheet_architect@3a6f02d#diff-4ac32a78649ca5bdd8e0ba38b7006a1e
[3]: randym/axlsx#536
@westonganger
Copy link
Owner Author

westonganger commented Feb 13, 2020 •
edited
Loading

SpreadsheetArchitect is now basically ready for the v4.0.0 release. I would just like to let the newly merged caxlsx changes and this libraries new changes to get sit for a couple weeks to see if any issues arise before cutting the release.

@westonganger
Copy link
Owner Author

v4.0.0 is now released which utilizes caxlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arambert @westonganger