-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #20 patch pHash to support alpha channel PNGs #23
Conversation
FYI Grass is a huge file. You might want to use smaller images in the future, just to keep repo size down. |
fixes #20 patch pHash to support alpha channel PNGs
regarding the huge grass file - agreed. |
@westonplatter How would I get this patch into my local gem? Remove and reinstall. Did this even get pushed to rubygems? (I'm new to this whole GEM-creation thing) |
related to installing off of github
…ted" This reverts commit 487af7f.
@toadle Great question! Are you using Bundler? If so, modify the Gemfile's phashion declaration to be,
I pushed the v1.0.8 version to github. @mperham If you're cool with pushing a release to RubyGems that would be awesome. Or you could add me as RubyGems author (via this http://guides.rubygems.org/command-reference/#gem_owner) and I can push a release too. I'm cool with either. |
@westonplatter Thx for the hard work. I just installed the thing and RSPEC still greenlights. Great! I'll try the mean PNGs now :-)! |
…el PNGs fix PR#20 => westonplatter#23
After a lengthy dicussion on #20, I'm suggesting,
The
ext/phashion_ext/pHash-0.9.6-png-patch.tar.gz
contains these changes, westonplatter/phash@ff255d2