Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #20 patch pHash to support alpha channel PNGs #23

Merged
merged 3 commits into from
Nov 26, 2013
Merged

fixes #20 patch pHash to support alpha channel PNGs #23

merged 3 commits into from
Nov 26, 2013

Conversation

westonplatter
Copy link
Owner

After a lengthy dicussion on #20, I'm suggesting,

  • merge and release the gem with this custom patched version of pHash
  • re-release once pHash pulls in patch version and move back to official pHash codebase

The ext/phashion_ext/pHash-0.9.6-png-patch.tar.gz contains these changes, westonplatter/phash@ff255d2

@mperham
Copy link
Collaborator

mperham commented Nov 26, 2013

FYI Grass is a huge file. You might want to use smaller images in the future, just to keep repo size down.

mperham added a commit that referenced this pull request Nov 26, 2013
fixes #20 patch pHash to support alpha channel PNGs
@mperham mperham merged commit 7a13ccd into westonplatter:master Nov 26, 2013
@westonplatter
Copy link
Owner Author

regarding the huge grass file - agreed.

@toadle
Copy link

toadle commented Nov 27, 2013

@westonplatter How would I get this patch into my local gem? Remove and reinstall. Did this even get pushed to rubygems? (I'm new to this whole GEM-creation thing)

westonplatter added a commit that referenced this pull request Nov 29, 2013
westonplatter added a commit that referenced this pull request Nov 29, 2013
@westonplatter
Copy link
Owner Author

@toadle Great question!

Are you using Bundler? If so, modify the Gemfile's phashion declaration to be,

gem "phashion",
  :github => "westonplatter/phashion", 
  :tag => "v1.0.8" 

I pushed the v1.0.8 version to github.

@mperham If you're cool with pushing a release to RubyGems that would be awesome. Or you could add me as RubyGems author (via this http://guides.rubygems.org/command-reference/#gem_owner) and I can push a release too. I'm cool with either.

@toadle
Copy link

toadle commented Dec 1, 2013

@westonplatter Thx for the hard work. I just installed the thing and RSPEC still greenlights. Great! I'll try the mean PNGs now :-)!

esergion pushed a commit to machinio/phashion that referenced this pull request Jun 10, 2019
ryoga-chan added a commit to ryoga-chan/phashion that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants