Add workaround for exporting wp.i18n to worker #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to make
wp.i18navailable in a Worker, Partytown throws an error when attempting to accesswp.i18n.__()because it is blocking the serialization of any property name that begins with "_". This is a workaround to prevent this from happening. It seems Partytown needs to conditionally prevent serializing these underscore-prefixed members based on the object that is being serialized.This works around the bug I filed at QwikDev#629
Note that I built the JS with
npm run buildand notnpm run build.prod. This prevents the scripts in thedebugdirectories from being minified.