Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main page title: Short bord red underline - follow the title alignement #2429

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

polmih
Copy link
Contributor

@polmih polmih commented Sep 26, 2024

If the main title is aligned to right (dir="rtl") the bottom red underline will follow the same alignement.

@Garneauma
Copy link
Contributor

Garneauma commented Oct 1, 2024

Pre-approved upon successful review. This is a minor change.

sites/main-page-title/_base.scss Outdated Show resolved Hide resolved
Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an example where:

<div dir=rtl>
   <hgroup id=wb-cont>
     <h1>Title 1</h1>
     <p>Group</p>
   </hgroup>
</div>

To represent situation when "rtl" is set on a parent element like "main" or "html"

@polmih
Copy link
Contributor Author

polmih commented Oct 9, 2024

Missing an example where:

<div dir=rtl>
   <hgroup id=wb-cont>
     <h1>Title 1</h1>
     <p>Group</p>
   </hgroup>
</div>

To represent situation when "rtl" is set on a parent element like "main" or "html"

The missing example is now added. Thanks

@Garneauma
Copy link
Contributor

@polmih Could you please fix the build issue?

Copy link
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code review, see my comments. I didn't tested locally.

sites/main-page-title/_base.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Version should be changed to 1.2 (index.json-ld line 20)
  • In "history" of both variations, add a history item for the addition of the LTR support (line 132 and line 164)
  • Add the newly created working examples links to the list on each variation accordingly.
  • Please add a breadcrumb item that refers to the documentation on each working example. I couldn't do so on the main example as it is shared for many components, but the new ones are specific to this component.

sites/main-page-title/index.json-ld Outdated Show resolved Hide resolved
sites/main-page-title/index.json-ld Show resolved Hide resolved
@duboisp
Copy link
Member

duboisp commented Oct 15, 2024

Pre-approved upon re-testing and after the documentation is fixed.

Copy link
Contributor

@Garneauma Garneauma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • index.json-ld - line 161: change to smpt_2
  • index.json-ld - line 239: change to mpt_4
  • index.json-ld - line 275: change to smpt_2
  • index.json-ld - line 311: change to smpt_2
  • index.json-ld - line 350: change to mpt_4
  • index.json-ld - line 373: change to smpt_2
  • implement other changes requested in comments

sites/main-page-title/index.json-ld Outdated Show resolved Hide resolved
sites/main-page-title/index.json-ld Outdated Show resolved Hide resolved
sites/main-page-title/main-page-title-align-right-en.md Outdated Show resolved Hide resolved
@Garneauma Garneauma merged commit de1f6df into wet-boew:master Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants