Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WV-546 SignIn Page - Misaligned SignIn with Twitter and SignIn with Apple buttons, misaligned logo icons, and incorrect text for 'Sign In with Twitter' #4165

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

WV-546 SignIn Page - Misaligned SignIn with Twitter and SignIn with Apple buttons, misaligned logo icons, and incorrect text for 'Sign In with Twitter' #4165

wants to merge 1 commit into from
+46 −17

Conversation

tejasaditya
Copy link
Contributor

What github.com/wevote/WebApp/issues does this fix?

WV-546 SignIn Page - Misaligned SignIn with Twitter and SignIn with Apple buttons, misaligned logo icons, and incorrect text for 'Sign In with Twitter'

Changes included this pull request?

  1. Apple and Twitter buttons were aligned and are more uniform.
  2. The text in the buttons and heading text are aligned.
  3. Logos for both buttons are same size and also aligned
  4. Twitter button was updated to use X terminology and match the new X platform style more
  5. Button are full length and cover end-to-end on mobile and are only 80% on desktop for better aesthetics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaleMcGrew DaleMcGrew Awaiting requested review from DaleMcGrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tejasaditya