Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show all panes when using action PaneSelect in a zoomed-in pane #3573

Closed
protiumx opened this issue Apr 20, 2023 · 3 comments
Closed
Labels
enhancement New feature or request fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.

Comments

@protiumx
Copy link

Is your feature request related to a problem? Please describe.
When in zoom mode, the action PaneSelect only shows the current zoomed panel as option.

Describe the solution you'd like
When calling PaneSelect all panes should be shown, meaning that the zoom mode must be toggled off if one pane has it activated. This will allow to easily jump to any other pane from a zoomed one.

As the zoom mode must be toggled off to show all panes, there will be 2 possible resolutions

  • Toggle zoom mode on the pane selected by the user
  • Do nothing. This would be similar to toggling the zoom mode off and changing the focus to the selected pane.

That could be resolved with a new configuration entry if needed.

Describe alternatives you've considered
None. At the moment if I want to chose a pane I need to toggle the zoom mode off.

@protiumx protiumx added the enhancement New feature or request label Apr 20, 2023
wez added a commit that referenced this issue Apr 21, 2023
@wez
Copy link
Owner

wez commented Apr 21, 2023

Oh, I hadn't thought of this. I just pushed a commit that will unzoom prior to showing the pane selector, and then reset the zoom state to the prior value when the action is processed.

It typically takes about an hour before commits are available as nightly builds for all platforms. Linux builds are the fastest to build and are often available within about 20 minutes. Windows and macOS builds take a bit longer.

Please take a few moments to try out the change and let me know how that works out. You can find the nightly downloads for your system in the wezterm installation docs.

If you prefer to use packages provided by your distribution or package manager of choice and don't want to replace that with a nightly download, keep in mind that you can download portable packages (eg: a .dmg file on macOS, a .zip file on Windows and an .AppImage file on Linux) that can be run without permanently installing or replacing an existing package, and can then simply be deleted once you no longer need them.

If you are eager and can build from source then you may be able to try this out more quickly.

@wez wez added the fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds. label Apr 21, 2023
@protiumx
Copy link
Author

Hi @wez, that's awesome!
I just tested the windows nightly, works like a charm 🚀

@wez wez closed this as completed Jul 12, 2023
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request fixed-in-nightly This is (or is assumed to be) fixed in the nightly builds.
Projects
None yet
Development

No branches or pull requests

2 participants