-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve matching of CharSelect #5532
Comments
FWIW, the results you are seeing right now are fuzzy matches, produced by https://crates.io/crates/fuzzy-matcher |
Strange, it should matching line related things first instead of linux then... Maybe it's worth implementing something like https://dlang.org/library/std/numeric/gap_weighted_similarity_normalized.html ? In my experience it does very good matching. |
Maybe we could replace the use of the fuzzy-matcher crate with nucleo, which is both much faster and uses the same scoring system as fzf 🤔 |
Imo nucleo looks good and if they're right about similar matching to fzf it'd certainly be better choice |
Tbh looks better then before What if to trick it by adding spaces before and after input string? Should probably trick matcher..? I would've tested some things myself (namely trying to implement gap weight similarity algorithm), but I'm very unfamiliar with rust and didn't really liked it when I tried |
This has more intuitive sorting; eg: `line` used to show the first match as `linux_endeavour` but now matches `LINEAR B IDEOGRAM VESSEL B212` first, which feels more relevant (has an exact prefix match). refs: #5532
I've switched this to nucleo in Note that once you select |
That is fair, it's way better then it was before and personally I'm ok with that, so, close when ready |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Is your feature request related to a problem? Please describe.
When I'm trying to get unicode characters it's extremely frustrating that results are completely unrelated to search. Example:
On top is
kitten unicode-input
, on bottom wezterm's CharSelect. Top results are fairly close to what I need (and to be honest look way better), bottom are absolutely not what I want to findDescribe the solution you'd like
Fuzzy search instead of what it's right now
Describe alternatives you've considered
Using kitty's char select which doesn't work with wezterm, i.e can't select characters or backspace to delete typed term
The text was updated successfully, but these errors were encountered: