Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Log Window #80

Closed
God-damnit-all opened this issue Dec 19, 2019 · 5 comments
Closed

Add Error Log Window #80

God-damnit-all opened this issue Dec 19, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@God-damnit-all
Copy link

God-damnit-all commented Dec 19, 2019

To make it easier to diagnose errors when spawned entirely from a GUI context, it would be desirable to add an error log window.

  • Default to not showing the window on startup (but config to make it show anyway)
  • Key assignment to show the window manually
  • Allow certain conditions (such as error loading config, or connectivity errors with ssh/mux) to show the window
  • The window would show a capture of the most recent log messages from the standard rust logging layer
@God-damnit-all God-damnit-all changed the title [FEATURE] weznotify {Low Priority} [FEATURE] weznotify ˡᵒʷ ᵖʳᶦᵒʳᶦᵗʸ Dec 19, 2019
@wez
Copy link
Owner

wez commented Dec 24, 2019

I think the current notifications are "OK" for their intended purpose, which is to let you know that something isn't working, rather than giving you a precise inventory of problems.

For the latter situation, I think that it is probably better overall if we had a separate window that we could show with an error log. I'm going to edit this issue to capture how I think that should work.

@wez wez changed the title [FEATURE] weznotify ˡᵒʷ ᵖʳᶦᵒʳᶦᵗʸ Add Error Log Window Dec 24, 2019
@wez wez added the enhancement New feature or request label Dec 24, 2019
@God-damnit-all
Copy link
Author

That's a good adaptation. Might I recommend configuration for tab flashing and/or user-selected sound file when an error does occur? (Startup being the exception.)

@wez
Copy link
Owner

wez commented Dec 25, 2019

Re: flashing/sounds: #3 is tracking the bell/alerting concept

wez added a commit that referenced this issue Jan 18, 2020
This is a very basic first approximation for the feature discussed
in the associated github issue.

Refs: #80
@wez
Copy link
Owner

wez commented Apr 12, 2020

As of bb9504d I think this is "good enough".

@wez wez closed this as completed Apr 12, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants