Add option to extend the osx non-native fullscreen behind the notch to the top of the screen #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so you can use the full screen if your terminal config already handles the notch.
… so you can use the full screen if your terminal config already handles the notch.
|
This is how it looks with the option enabled:
|
wez
reviewed
Jun 29, 2024
There was a problem hiding this comment.
Thanks for this!
Please also add a page to the docs; you can use https://github.com/wez/wezterm/blob/main/docs/config/lua/config/macos_window_background_blur.md?plain=1 as a basis for it, creating a page for this new option alongside that one, but use {{since('nightly')}} for the version tag.
You can run ./ci/build-docs.sh serve to run the docs locally and preview how it looks.
| None | ||
| let border_dimensions = if window_state.contains(WindowState::FULL_SCREEN) | ||
| && !native_full_screen | ||
| && !_config.macos_fullscreen_extend_behind_notch |
There was a problem hiding this comment.
Please rename the _config function parameter to config; the leading underscore is a rust convention to indicate that a variable/binding is unused. Since it is now used, that prefix should be removed.
Suggested change
| && !_config.macos_fullscreen_extend_behind_notch | |
| && !config.macos_fullscreen_extend_behind_notch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a boolean option:
macos_fullscreen_extend_behind_notchwhich is checked before the osx window calculates the borders to make non-native fullscreen go all the way to the top of a mac laptop with a notch, for use-cases (like mine) where that is useful.I was also having issues with multiple monitors making the notch-avoiding window jump up and down when the active monitor changes on the release version, but I haven't been able to check if that issue still exists on
mainand whether or not this option fixes it. I will once I'm back with my external monitor!