Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu -> 0.20 #5814

Closed
wants to merge 1 commit into from
Closed

wgpu -> 0.20 #5814

wants to merge 1 commit into from

Conversation

wez
Copy link
Owner

@wez wez commented Jul 14, 2024

This compiles, but when I run it on X11 I get a fully transparent window.

I have not tried to debug this yet.
I'm throwing this up here to see if it compile on !linux.

This is based on a revert of bf07f6d which was where wgpu 0.19 was rolled back previously.

This compiles, but when I run it on X11 I get a fully transparent
window.

I have not tried to debug this yet.
@wez
Copy link
Owner Author

wez commented Sep 14, 2024

Updated to wgpu 22.1.

Still gives me a transparent window under X11. I don't have time to dig into this right now.
I do want to note that you can see wgpu's trace stuff by explicitly enabling it:

 WEZTERM_LOG=wgpu_core=trace,wgpu_hal=trace ./target/debug/wezterm start sleep 1

There's no glaringly obvious reason why this might be broken in this way, probably wouldn't hurt to engage with the wgpu folks for suggestions, but I have no bandwidth for this right now.

impl HasWindowHandle for XWindowInner {
fn window_handle(&self) -> Result<WindowHandle<'_>, HandleError> {
let mut handle =
XcbWindowHandle::new(NonZeroU32::new(self.window_id.resource_id()).expect("non-zero"));
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves my blank window issue:

Suggested change
XcbWindowHandle::new(NonZeroU32::new(self.window_id.resource_id()).expect("non-zero"));
XcbWindowHandle::new(NonZeroU32::new(self.child_id.resource_id()).expect("non-zero"));

@wez wez closed this in 09ac8c5 Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant