Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ghost space left by SplitPane with top_level=true #5969

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ghost space left by SplitPane with top_level=true #5969

wants to merge 1 commit into from

Commits on Aug 15, 2024

  1. Fix wez#2579, wez#4984 

    When there is more than one pane in the tab, the tab.resize() is
called and the tab resize logic is reused to correctly resize all the
panes in the tab before adding the new pane split, so the new split
pane will not overwrite any existing pane.

The issue seems to be that after this resize, the tab "remembers" its
new size, and when the new split pane is closed, the tab is left with
ghost space which cannot be reused.

The fix is quite simple: we just need to immediately resize the tab
back to its original proportions. Since the underlying panes have
already been resized by tab.resize(), we don't need to keep the
restricted tab size.
    @boazy
    boazy committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f53e4ec View commit details
    Browse the repository at this point in the history