Fix alternate-screen scrolling #6186
Open
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't demonstrate a problem, since the screen contents are correct. The actual problem is that a count of the number of lines discarded from the top of the screen, wasn't being tracked.
The alternate-screen mode disables scrollback. This means that we delete lines off of the top of the screen when scrolling, without saving them. But we weren't keeping a count of those lines, which meant a stable index was lost; leaving the mux-server unable to properly track scrolling. Now we keep track of the stable_row_index_offset, even when there is no scrollback. This turns out to be the exact same logic as when scrollback is enabled, but after "erase_scrollback" has been called. In both cases, stable_row_index_offset is used to count the number of scrollback-lines, that don't exist in the buffer. As per issue wez#6166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Wez,
Did the test case you requested, but it didn't demonstrate the problem. So
after staring at it a bit more, found this one-liner. Hope it's okay.