-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add energy and kcal values to ingredient logging/adding forms #585
Conversation
e92409c
to
3d1e6ed
Compare
does the preview only show when you select an ingredient from the quicklist? |
the preview should not show if you don't have any ingredient in the form |
note: the image doesn't seem to be set yet, but at least the UI is now ready for it
1e6285b
to
eeec221
Compare
🚀 |
see #592 for followup |
When:
the app already shows you a list of recently used ingredients, as well a form with the ingredient, and amount.
what this PR does:
this should be handy because often i log an entry (save the form), and then check my diary and realize it isn't quite what i wanted. this is especially true when you are dealing with an ingredient on your plate that doesn't have an exact match in the database, and you have to use something "similar": it's nice to be able to see if the values make sense before you log it.
I also added a couple of cleanups and refactors to this PR. notably, the 2 mentioned forms were quite similar, so i merged them into 1 class.
future work: add a warning icon to the list tile in case the ingredient is missing a field that you need to to track against a goal (e.g. fiber)