popup ingredient details in typeahead suggestions and recently used #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, ideally we would query the regular ingredient API, then we would have access to all fields and could decide what to show |
|
Just tested this, I like it! However, I am always getting a render flex overflow error here (it seems only the first time?). I would also remove the g-per-body-kg column, that's only useful for the whole plan |
|
blocked on wger-project/wger#1713 |
have updated the test and the production server |
Dieterbe
force-pushed
the
ingredient-details
branch
from
4b85867
to
cd7d291
Compare
Dieterbe
force-pushed
the
ingredient-details
branch
from
cd7d291
to
a6cd87c
Compare
Dieterbe
force-pushed
the
ingredient-details
branch
from
a6cd87c
to
c11dede
Compare
Dieterbe
force-pushed
the
ingredient-details
branch
from
c11dede
to
1ae3f33
Compare
Dieterbe
force-pushed
the
ingredient-details
branch
from
9df2425
to
62e1bc0
Compare
ingredient details dialog:
- give it close/continue buttons to load into selection
- always use image property from loaded ingredient
this is a bit slower, but:
* more consistent (no need to support absolute vs relative URL's
separately)
* cleaner (no need to pass it thru explicitly)
* more future proof: we will get rid of the dedicated
/ingredient/search endpoint which gives us images before we load
the full ingredient. in the future we will simply load the
ingredients, completely, all at once.
* allows for easier code reuse with barcode scan result dialog
barcode scan result dialog:
- show image and detailed nutrition table
- support a loading spinner
- simplify error handling
- deduplicate code between found & not found
- share code with ingredient details dialog
Dieterbe
force-pushed
the
ingredient-details
branch
from
62e1bc0
to
dc1f220
Compare
| @@ -353,7 +353,7 @@ class IngredientFormState extends State<IngredientForm> { | |||
| child: Column( | |||
| children: [ | |||
| Text( | |||
| 'Macros preview', | |||
| 'Macros preview', // TODO fix l10n | |||
| ), | ||
| ), | ||
| if (snapshot.hasData && ingredient!.licenseObjectURl == null) | ||
| Text('Source: ${source!}'), |
| ), | ||
| ), | ||
| if (ingredient != null && ingredient.licenseObjectURl == null) | ||
| Text('Source: ${source!}'), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unfortunately, we only get the image when getting suggestions. not when using the ingredients API or when browsing recently used ingredients. this would be a nice thing to add to the backend @rolandgeider :) i also think a link to the "upstream source" could be nice. (e.g. to OFF or USDA if applicable)